Skip to content
Verified Commit d500368f authored by Julius Künzel's avatar Julius Künzel 💬
Browse files

Port away from deprecated KUrlRequester::setFilter()

parent 08efca00
Pipeline #423786 failed with stages
in 6 minutes and 19 seconds
  • Reporter

    Hello! I'm unable to build the current master due to this change:

    /home/bruno/build/kdenlive/src/assets/view/widgets/urlparamwidget.cpp:25:20: error: no member named 'setNameFilter' in 'KUrlRequester'; did you mean 'setFilter'?
            urlwidget->setNameFilter(filter);
                       ^~~~~~~~~~~~~
                       setFilter
    /usr/include/KF5/KIOWidgets/kurlrequester.h:158:10: note: 'setFilter' declared here
        void setFilter(const QString &filter);
             ^
    1 error generated.
    make[2]: *** [src/CMakeFiles/kdenliveLib.dir/build.make:782: src/CMakeFiles/kdenliveLib.dir/assets/view/widgets/urlparamwidget.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    /home/bruno/build/kdenlive/src/dialogs/renderwidget.cpp:924:22: error: no member named 'setNameFilter' in 'KUrlRequester'; did you mean 'setFilter'?
        m_view.out_file->setNameFilter("*." + profile->extension());
                         ^~~~~~~~~~~~~
                         setFilter
    /usr/include/KF5/KIOWidgets/kurlrequester.h:158:10: note: 'setFilter' declared here
        void setFilter(const QString &filter);
             ^
    1 error generated.
    make[2]: *** [src/CMakeFiles/kdenliveLib.dir/build.make:1496: src/CMakeFiles/kdenliveLib.dir/dialogs/renderwidget.cpp.o] Error 1
    make[1]: *** [CMakeFiles/Makefile2:2600: src/CMakeFiles/kdenliveLib.dir/all] Error 2
    make: *** [Makefile:146: all] Error 2

    I'm running Neon Testing which has (at least per cmake information), KF 5.108.0, but the build fails. Could this be an issue with my system?

    Edited by Bruno Santos
  • Developer

    Yesterday I updated craft first. Then I could build the master. So, make sure all libs are updated first before you build the master.

  • Reporter

    Thanks @emohr that was the problem! 🤦

    Should we report the build warnings? There are maaany warnings "zero as null pointer constant".

  • Developer

    I saw these warnings as well. If you still have the warnings, post it here (but not the warnings about depreciated strings).

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment