Skip to content
Commit 505983e5 authored by Eric Jiang's avatar Eric Jiang Committed by Jean-Baptiste Mardelle
Browse files

Don't wait for a clip to be ready to get its type 

This fixes a bug where after duplicating a title clip, the context
menu's "Edit Clip" action is disabled because the clip's type is thought
to be Unknown.

BUG: 456619
parent 93046a1c
Pipeline #204273 passed with stage
in 8 minutes and 40 seconds
Hide whitespace changes
Inline Side-by-side
  • Stephen Esseenyne @stephenesseenyne ·

    Thank you for this commit. I am afraid, once the duplicated clip has been edited with new text, the clip monitor is showing the source clip instead of the duplicated clip so when I Overwrite Clip Zone in Timeline it is using the source clip and not the new/duplcated clip.

  • Stephen Esseenyne @stephenesseenyne

    mentioned in commit d9d2d81e

     ·

    mentioned in commit d9d2d81e

    Toggle commit list
  • Eric Jiang @erjiang ·
    Author Developer

    You're right, looks like that's a pre-existing problem that this bug did not fix. Even though the selection in the project bin switches to the new clip, the clip monitor is not updated. I don't currently know what the fix is, but maybe somebody else would know exactly what to change.

    A possible bandage fix would be to update the clip monitor to the correct clip after you update the title, but that doesn't fix the root issue.

  • Jean-Baptiste Mardelle @mardelle ·
    Developer

    I will take care of this monitor update issue and keep you updated, thanks for reporting.

  • Jean-Baptiste Mardelle @mardelle ·
    Developer

    Ok, duplicate clip not showing up correctly in monitor should now be fixed in git.

  • Stephen Esseenyne @stephenesseenyne ·

    I've just tested this fix and it's a thumbs up. Thank you very much for addressing both the Edit Clip and Clip Monitor issues. :-)

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment