Skip to content
Snippets Groups Projects
Commit 72552399 authored by David Faure's avatar David Faure
Browse files

Fix KDirListerCache crash with two listers for an empty dir in the cache.

The wrong optimization if (!itemU->lstItems.isEmpty()) meant that if
the cached dir is empty, we didn't create a CachedItemsJob. If there is
also no ListJob happening, then the lister would just be forever in the
listersCurrentlyListing list, which would lead to crashes later on.

The user-visible bug was hard to trigger (needed autofs enabled, I suppose to
trigger [1], although not sure why it's related), but after enabling DEBUG_CACHE,
simply clicking on the trash place entry in dolphin would trigger an assert.

[1] "KDirListerCache::forgetDirs: Not adding a watch on "file:///" because it contains a manually mounted subdir"

BUG: 278431
FIXED-IN: 4.14.17
parent 7af792f2
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment