Skip to content
Commit 0cc054d1 authored by Ignaz Forster's avatar Ignaz Forster Committed by Albert Astals Cid
Browse files

Don't show overwrite dialog if file name is empty

Programs using KFileDialog's setConfirmOverwrite(true) (e.g. LibreOffice with KDE4 integration, Mozilla products with KDE4 integration, several components of the PIM suite) will trigger the following strange behaviour:
If the file name in the save file dialog is empty and the user selects "Save", the dialog will ask if you want to overwrite the current directory (instead of just ignoring the empty input).

By moving the query below the directory checks the order is correct again, showing the overwrite confirmation dialog only if the field contains a unique filename.

Looking at the code this also affects Frameworks 5 / kio, though I haven't tested it yet.

Acked by dfaure

REVIEW: 120127
parent a0f36a80
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment