Do not rename files unexpectedly when changing the URL
If the role editor loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens before DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly. The solution is to establish the connection to the slotRoleEditingFinished signal only when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes. BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
Showing
- dolphin/src/kitemviews/kstandarditemlistwidget.cpp 16 additions, 19 deletionsdolphin/src/kitemviews/kstandarditemlistwidget.cpp
- dolphin/src/kitemviews/kstandarditemlistwidget.h 2 additions, 2 deletionsdolphin/src/kitemviews/kstandarditemlistwidget.h
- dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 2 additions, 13 deletionsdolphin/src/kitemviews/private/kitemlistroleeditor.cpp
- dolphin/src/kitemviews/private/kitemlistroleeditor.h 2 additions, 6 deletionsdolphin/src/kitemviews/private/kitemlistroleeditor.h
Loading
Please register or sign in to comment