Skip to content
Commit 65b91bf4 authored by Waqar Ahmed's avatar Waqar Ahmed Committed by Christoph Cullmann
Browse files

Fix crash on viewspace close

When we close a viewspace, we delete all the widgets implicitly (they
are part of QStackWidget which controls their lifetime). Moving around
widgets doesn't make much sense so instead, just skip them and let them
be killed.

Added a related test case.

As a drive-by, I discovered that there was still a check in place which
would prompt you and make sure you wanted to close the viewspace if the
viewspace has widgets. This is kind of wrong as we don't need to do this.
We should call the widget's shouldClose method and the widget should
prompt the user if necessary.


(cherry picked from commit 315a92d6)
parent 6d58cf20
Pipeline #463592 canceled with stages
in 13 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment