Skip to content
Commit 24b0edd1 authored by Michael Pyne's avatar Michael Pyne
Browse files

Fix crash with threaded file loading.

Although Qt protects access to functions in the GUI thread (where I was
seeing crashes in the new threaded file loading code in some
situations), as long as you use signals/slots, Qt Concurrent doesn't do
anything to keep your non-GUI threaded code from trampling on each
other.

Which is obvious enough, in retrospect, but that seems to have been the
reason for the crashes I was sometimes seeing (TagLib and/or FileHandle
not being thread-safe).

The immediate bugfix is to serialize access into FileHandle/TagLib file
reading code in DirectoryLoader, though I also did some cleanups in the
process of debugging that I think are worth keeping.
parent 0930c648
Pipeline #1038 passed with stage
in 9 minutes and 5 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment