Skip to content
Commit 984b9737 authored by Huon Imberger's avatar Huon Imberger
Browse files

Allow dragging from View mode to external applications

Summary:
This patch adds drag functionality to {nav View} mode. A
drag operation is only initiated if dragging wouldn't
otherwise do something, e.g. when zoomed and the image is
pannable, or the crop tool is active.

In order to get a drag pixmap for all cases (videos
included), we use a ThumbnailProvider to generate a file
preview. However, if the image is modified, we generate a
new pixmap using the edited version. Using
`MimeTypeUtils::selectionMimeData`, this should mean the
drag pixmap always matches the image the receiving
application gets.

BUG: 386034
FIXED-IN: 18.08.0

{F5781358}

Test Plan:
Drag from View mode, comparison mode.
Try raster, SVG, and video file types, including when the
image is modified (cropped or rotated).
Panning a zoomed image should still be possible.
Drag operation should always get a thumbnail/icon pixmap
representing the dropped image.

Reviewers: #gwenview, rkflx

Reviewed By: #gwenview, rkflx

Tags: #gwenview

Differential Revision: https://phabricator.kde.org/D11877
parent faa19b06
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment