Skip to content
Commit 59227541 authored by rk flx's avatar rk flx Committed by Luigi Toscano
Browse files

Re-enable all tests

Summary:
documenttest: Port away from obsolete API.
documenttest: only compile when KDcraw is found
thumbnailprovidertest: Port to QUrl.
thumbnailprovidertest, documenttest: count remote tests as skipped when unavailable, instead of silently ignoring them (also: no more SkipSingle in Qt5)

Depends on D5749

Test Plan:
documenttest:
- Run documenttest: no failures, 5 skipped tests.
- With GV_REMOTE_TESTS_BASE_URL set: ./gwenview-remote-tests/test.png created on remote host, no failures, 3 skipped tests.
- Execute ./fetch_testing_raw.sh: no failures, 0 skipped tests.
- Uninstall libkdcraw-devel: cmake mentions optional package not being found, documenttest not compiled.

thumbnailprovidertest:
- Run thumbnailprovidertest: no failures, 1 skipped test.
- With GV_REMOTE_TESTS_BASE_URL set: 0 skipped tests.

Reviewers: ltoscano, sandsmark, gateau

Reviewed By: ltoscano

Differential Revision: https://phabricator.kde.org/D5751
parent 5b0749f6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment