Skip to content
Commit 85ad152e authored by Harald Sitter's avatar Harald Sitter 🐧
Browse files

substantially refine the path x-platform path displaying

Summary:
- File::name is now File::decodedName
- new File::displayName which properly applies separators to the name
  (on Windows src/ should be src\)

The motivation behind this change is to force us having to make a decision
if we want the low-overhead name or the high-overhead UI name.

- File::fullPath is now File::displayPath for the same reason as above
- new File::url as a convenience wrapper used by the display* functions
  to construct a full URL out of their tree so we can determine whether
  the path is local or remote (scheme file:// vs. http:// etc.)
- RadialMap::Widget::mouseMoveEvent had its tooltip adjusted to not
  resolve it against the held tree but rather the entities tree. This was
  inconsistent with hover signals emitted and caused remote paths to
  get improperly displayed like local paths in the tooltip while being
  correctly displayed as URLs in the rest of the UI

Test Plan:
- paths work beautifully on win32
- filelighting over sftp:// also has correct paths now

Reviewers: sandsmark

Subscribers: kde-utils-devel

Differential Revision: https://phabricator.kde.org/D9285
parent ba156e17
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment