Skip to content
Commit 928e79cf authored by Stephen Kelly's avatar Stephen Kelly
Browse files

Fix _ecm_update_iconcache to only update the install location

Use the CMAKE_INSTALL_PREFIX to ensure that only a file in the install
location will be touched.  Otherwise a user running

 make install

as root would create root-owned files in the build directory.

Use the cmake -E touch command to update the mtime of the directory.
That command exists since late 2007, but this manual file creation
workaround pre-dates that by a few months (kdelibs SVN revision 691973).

There is no chance any calling code is already passing an absolute path
here because later in the function it is already used together with a
CMAKE_INSTALL_PREFIX.

Inspired-by: REVIEW 127445
parent 09008700
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment