Skip to content
Commit e9843a8c authored by Albert Astals Cid's avatar Albert Astals Cid
Browse files

Call KLocalizedString::setApplicationDomain("dragonplayer");

dragonplayer is using
   -DTRANSLATION_DOMAIN=\"dragonplayer\"
that is wrong for applications, apps need to use
   KLocalizedString::setApplicationDomain
since that is needed for some things like the transltators tab in the about
dialog.

I have not removed -DTRANSLATION_DOMAIN=\"dragonplayer\" because on the other hand
this code is also a library (i.e. the dragonplayer kpart).

The "being pedanticly correct" fix would be using -DTRANSLATION_DOMAIN=\"dragonplayer\"
only to compile the files that are part of the kpart but that's prone to
break at some point and using both KLocalizedString::setApplicationDomain and
-DTRANSLATION_DOMAIN does not create any problem so i went that route

CCMAIL: lukas@kde.org
parent 68f3cfc4
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment