Skip to content
Commit d00b531c authored by Albert Astals Cid's avatar Albert Astals Cid
Browse files

Call KLocalizedString::setApplicationDomain("dolphin");

dolphin is using
   -DTRANSLATION_DOMAIN=\"dolphin\"
that is wrong for applications, apps need to use
   KLocalizedString::setApplicationDomain
since that makes some other things like the transltators tab in the about
dialog show.

I have not removed -DTRANSLATION_DOMAIN=\"dolphin\" because on the other hand
this code is also a library (i.e. the dolphin kpart).

The "being pedandly correct" fix would be using -DTRANSLATION_DOMAIN=\"dolphin\"
only to compile the files that are part of the kpart but that's prone to
break at some point and using both KLocalizedString::setApplicationDomain and
-DTRANSLATION_DOMAIN does not create any problem so i went that route

CCMAIL: kfm-devel@kde.org
parent 581ee6d0
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment