Skip to content
Commit 10944d41 authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by Emmanuel Pescosta
Browse files

Scrolling fixes for Dolphin

KItemListSmoothScroller::handleWheelEvent has some issues:
1. When I scroll file list holding mouse over the list, one mouse wheel tick corresponds
   to 1/4 page interval, but when I hover on QScrollBar, one wheel tick corresponds to
   1 page interval.
2. In KItemListSmoothScroller::eventFilter we don't return true, so that QScrollBar also
   handles this event, and total scroll interval is m_scrollBar->pageStep() +
   m_scrollBar->singleStep().
3. When I use touchpad that supports smooth scrolling via XInput2, and I hover it over
   QScrollBar, I can only scroll content if I move my fingers very fast, because
   numSteps = event->delta() / 8 / 15 is just zero unless I move very fast
   (event->delta() in this case is less than 120).
4. Holding Shift while scrolling has no effect when holding mouse over QScrollBar in
   contrast to scrolling faster when holding mouse over file list.

The patch eliminates all these issues making the behavior of KItemListSmoothScroller the
same as in KItemListContainer::wheelEvent, adding support for QWheelEvent::pixelDelta()
and removing usage of deprecated QWheelEvent::delta().

REVIEW: 124670
FIXED-IN: 15.12.0
parent 9ed9689c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment