Skip to content
Commit 061325c5 authored by Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez 🐧
Browse files

Unify error message backend classes into InlineMessage 

Makes it easier to have good frontend components for them
parent e7e7f5bc
Hide whitespace changes
Inline Side-by-side
    • Nate Graham @ngraham ·
      Developer

      @apol This commit breaks Discover's main view:

      QQmlComponent: Component is not ready
file:///home/nate/kde/usr/lib64/qml/org/kde/kirigami.2/PageRow.qml:904: Error: Error while loading page: qrc:/qml/BrowsingPage.qml:25 Type DiscoverInlineMessage unavailable
qrc:/qml/DiscoverInlineMessage.qml:22 "Kirigami.InlineMessage.topInset" is not available due to component versioning.
    • Nate Graham @ngraham ·
      Developer

      Fixed with 3e5f5aec. Let me know if that's not the ideal fix, but I though it was important not to let master stay broken for too long.

    • Aleix Pol Gonzalez 🐧 @apol ·
      Author Developer

      oooooh right, forgot to send the kirigami change... I don't think it was important, it can stay like this as long as it looks correct. Thanks for this!

    • Please register or sign in to reply
  • Nate Graham @ngraham

    mentioned in commit 3e5f5aec

     ·

    mentioned in commit 3e5f5aec

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment