Third time! The Selection modifiers patch!!!
This refactors polygonal, elliptical, and rectangular selection tools to use a basic selection tool template which unifies previously duplicated code. The template overrides the ability to execute alternate actions, but none of those tools supported alternate actions previously and the ellipse and rectangle were already overriding the modifier keys to begin with. Shift: add to selection Alt: subtract from selection Shift+Alt: intersect current selection Ctrl: replace selection Certain key combinations allow users the ability to expose the modifier keys to the base tool, i.e. to make proportional / translated / scaled alterations using ctrl/alt/shift. 1) If the user clicks first and then presses modifier keys, those modifier keys will only alter the selection method. 2) If the user presses modifier keys first and then clicks, the selection method is locked in, and subsequent modifier keystrokes will change how the selection is drawn. 3) If the underlying tool never takes modifier keys, modifier keys will always alter the selection method. Note: the bezier curve selection tool doesn't support the modifiers yet. Patch by Michael Abrahams. Thanks! CCMAIL: miabraha@gmail.com CCMAIL: kimageshop@kde.org CCMAIL: animtim@gmail.com, info@davidrevoy.com REVIEW: 123833 BUG: 315255 BUG: 348234 NOTE: Changing the secondary invocation action is still broken, but that's not the fault of this patch, that's another bug!
parent
a9c99c92
Please register or sign in to comment