Last.fm plugin: major rework of configuration and more
This work started as an attempt to fix bug 306134. I figured out that the synchronous KWallet API is simply dangerous, and the async one must be used. But that meant to make LastFmServiceConfig a "living" object with updated() signal, which triggered refactoring of all its usage. Users of LastFmServiceConfig now watch for its changes and should act appropriately. The LastFmServiceConfig now has only one instance shared between LastFmService and LastFmServiceSettings - I had to introduce another shared library because KCM modules use separate library, silly. Moreover, some extremely ugly things in Last.fm plugin got reworked to me clean and maintainable, reducing code duplication. Patrick, please tests whether this still builds on Windows, I hope I've done KDE_EXPORT/KDE_IMPORT right, but I cannot test under Linux. CHANGES: * When configuring Last.fm plug-in, the changes are now applied immediately in most places. BUGFIXES: * Fix suboptimal KWallet usage in Last.fm plugin. * Fix crash in Last.fm plugin caused by sloppy KWallet usage. BUG: 311331 BUG: 292096 BUG: 306134 FIXED-IN: 2.7 DIGEST: Last.fm plugin configuration reworked for smoother experience CCMAIL: Patrick von Reth <vonreth@kde.org>
Showing
- ChangeLog 4 additions, 0 deletionsChangeLog
- src/services/lastfm/CMakeLists.txt 15 additions, 2 deletionssrc/services/lastfm/CMakeLists.txt
- src/services/lastfm/LastFmService.cpp 166 additions, 147 deletionssrc/services/lastfm/LastFmService.cpp
- src/services/lastfm/LastFmService.h 9 additions, 5 deletionssrc/services/lastfm/LastFmService.h
- src/services/lastfm/LastFmServiceCollection.cpp 5 additions, 7 deletionssrc/services/lastfm/LastFmServiceCollection.cpp
- src/services/lastfm/LastFmServiceCollection.h 1 addition, 2 deletionssrc/services/lastfm/LastFmServiceCollection.h
- src/services/lastfm/LastFmServiceConfig.cpp 160 additions, 110 deletionssrc/services/lastfm/LastFmServiceConfig.cpp
- src/services/lastfm/LastFmServiceConfig.h 50 additions, 24 deletionssrc/services/lastfm/LastFmServiceConfig.h
- src/services/lastfm/LastFmServiceSettings.cpp 37 additions, 41 deletionssrc/services/lastfm/LastFmServiceSettings.cpp
- src/services/lastfm/LastFmServiceSettings.h 3 additions, 1 deletionsrc/services/lastfm/LastFmServiceSettings.h
- src/services/lastfm/LastFmTreeModel.cpp 4 additions, 4 deletionssrc/services/lastfm/LastFmTreeModel.cpp
- src/services/lastfm/LastFmTreeModel.h 1 addition, 2 deletionssrc/services/lastfm/LastFmTreeModel.h
- src/services/lastfm/ScrobblerAdapter.cpp 3 additions, 4 deletionssrc/services/lastfm/ScrobblerAdapter.cpp
- src/services/lastfm/ScrobblerAdapter.h 3 additions, 2 deletionssrc/services/lastfm/ScrobblerAdapter.h
- src/services/lastfm/SynchronizationAdapter.cpp 5 additions, 6 deletionssrc/services/lastfm/SynchronizationAdapter.cpp
- src/services/lastfm/SynchronizationAdapter.h 3 additions, 2 deletionssrc/services/lastfm/SynchronizationAdapter.h
- src/services/lastfm/amarok_lastfm_shared_export.h 36 additions, 0 deletionssrc/services/lastfm/amarok_lastfm_shared_export.h
- src/services/lastfm/meta/LastFmMeta.cpp 0 additions, 9 deletionssrc/services/lastfm/meta/LastFmMeta.cpp
- src/services/lastfm/meta/LastFmMeta.h 1 addition, 1 deletionsrc/services/lastfm/meta/LastFmMeta.h
Loading
Please register or sign in to comment