Meta::Album: introduce canUpdateCompilation(), setCompilation()
and convert subclasses to use these. Many many subclasses already had equivalent methods, this reduces code duplication and eliminates one static_cast. Some subclasses had equivalent methods but never used them, these are deleted in order to avoid dead code. This is a prerequisite for next commit that unifies album actions across collections. This is rather a bigger change, so I'm CCing list - if anyone opposes, raise your voice. CCMAIL: amarok-devel@kde.org
Showing
- src/amarokurls/BookmarkTreeView.cpp 0 additions, 1 deletionsrc/amarokurls/BookmarkTreeView.cpp
- src/core-impl/collections/audiocd/AudioCdCollection.cpp 1 addition, 1 deletionsrc/core-impl/collections/audiocd/AudioCdCollection.cpp
- src/core-impl/collections/audiocd/AudioCdMeta.cpp 13 additions, 7 deletionssrc/core-impl/collections/audiocd/AudioCdMeta.cpp
- src/core-impl/collections/audiocd/AudioCdMeta.h 3 additions, 1 deletionsrc/core-impl/collections/audiocd/AudioCdMeta.h
- src/core-impl/collections/daap/DaapMeta.cpp 0 additions, 6 deletionssrc/core-impl/collections/daap/DaapMeta.cpp
- src/core-impl/collections/daap/DaapMeta.h 0 additions, 1 deletionsrc/core-impl/collections/daap/DaapMeta.h
- src/core-impl/collections/db/sql/SqlMeta.cpp 8 additions, 0 deletionssrc/core-impl/collections/db/sql/SqlMeta.cpp
- src/core-impl/collections/db/sql/SqlMeta.h 2 additions, 11 deletionssrc/core-impl/collections/db/sql/SqlMeta.h
- src/core-impl/collections/ipodcollection/IpodMeta.cpp 13 additions, 0 deletionssrc/core-impl/collections/ipodcollection/IpodMeta.cpp
- src/core-impl/collections/ipodcollection/IpodMeta.h 3 additions, 0 deletionssrc/core-impl/collections/ipodcollection/IpodMeta.h
- src/core-impl/collections/support/MemoryMeta.cpp 19 additions, 1 deletionsrc/core-impl/collections/support/MemoryMeta.cpp
- src/core-impl/collections/support/MemoryMeta.h 14 additions, 3 deletionssrc/core-impl/collections/support/MemoryMeta.h
- src/core-impl/collections/upnpcollection/UpnpMeta.cpp 0 additions, 6 deletionssrc/core-impl/collections/upnpcollection/UpnpMeta.cpp
- src/core-impl/collections/upnpcollection/UpnpMeta.h 0 additions, 1 deletionsrc/core-impl/collections/upnpcollection/UpnpMeta.h
- src/core-impl/meta/timecode/TimecodeMeta.cpp 0 additions, 5 deletionssrc/core-impl/meta/timecode/TimecodeMeta.cpp
- src/core-impl/meta/timecode/TimecodeMeta.h 0 additions, 1 deletionsrc/core-impl/meta/timecode/TimecodeMeta.h
- src/core/meta/Meta.h 13 additions, 0 deletionssrc/core/meta/Meta.h
- src/services/ServiceMetaBase.cpp 11 additions, 6 deletionssrc/services/ServiceMetaBase.cpp
- src/services/ServiceMetaBase.h 3 additions, 1 deletionsrc/services/ServiceMetaBase.h
- src/services/amazon/AmazonParser.cpp 1 addition, 1 deletionsrc/services/amazon/AmazonParser.cpp
Loading
Please register or sign in to comment