Skip to content
Commit c48ae5f8 authored by David Faure's avatar David Faure
Browse files

Resourcebase docu: don't call changeCommitted from itemRemoved.

Summary:
This attempts to modify an item that was already removed from the DB,
with a "No items found" warning as a result.

Calling changeProcessed() is enough.
That's what most resources do already (knut, maildir, mbox, icaldir,
ical, vcard, kalarmdir, contacts, openxchange...).

It gets harder for resources that have a generic slot though
(e.g. GoogleResource::slotGenericJobFinished or
TomboyNotesResource::onItemChangeCommitted).
The davgroupware resource shows a possible solution for that:
setting and testing modifyJob->property("isRemoval").toBool()

MixedMaildirResource::itemRemovedResult also seems wrong and easily fixable.

Test Plan: FatCRM's unittests no longer show that warning

Reviewers: dvratil, vkrause

Reviewed By: vkrause

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D13756
parent 87cb83d7
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment